chore: minor improvements and bug fixes - #1
Merged
Merged
Conversation
Cod3ddy
commented
Jun 2, 2026
Cod3ddy
commented
Owner
- chore: remove hardcoded slice of countries' details
- chore: parse embedded countries' data from json
- fix: updat the doc, sanja has now migrated and started adhering to the E.164 format
- chore: add an errror for when a phone number execeeds the max e.164 length
- fix: the normalizer now conforms to the e.164 standard
- fix: remove typo, remove 'g' and replace with '9'
Owner
Author
you can read more about e.164 standard here: E.164 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.